refactor(AE): VerneMQ RPC#1194
Merged
davidebriani merged 1 commit intoastarte-platform:feature/erlang-rpcfrom Apr 9, 2025
Merged
refactor(AE): VerneMQ RPC#1194davidebriani merged 1 commit intoastarte-platform:feature/erlang-rpcfrom
davidebriani merged 1 commit intoastarte-platform:feature/erlang-rpcfrom
Conversation
lusergit
force-pushed
the
refactor/ae-verne-rpc
branch
3 times, most recently
from
1c8e9fc to
c9aa16a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/erlang-rpc #1194 +/- ##
======================================================
- Coverage 80.42% 80.39% -0.03%
======================================================
Files 83 84 +1
Lines 1941 1933 -8
======================================================
- Hits 1561 1554 -7
+ Misses 380 379 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lusergit
requested review from
Annopaolo and
davidebriani
and removed request for
Annopaolo
davidebriani
requested changes
Apr 7, 2025
apps/astarte_appengine_api/test/astarte_appengine_api/device/device_test.exs
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
refactor/ae-verne-rpc
branch
2 times, most recently
from
1cd1a07 to
d72ea8a
Compare
Refactors the logic to handle RPC calls with astarte VerneMQ Plugin, using the new erlang clustering strategy. AE now calls an RPC server shared among all VerneMQ plugin replicas. Tests are reqorked too to mock RPC calls and answers from the server Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
lusergit
force-pushed
the
refactor/ae-verne-rpc
branch
from
d72ea8a to
5cda927
Compare
davidebriani
approved these changes
Apr 9, 2025
davidebriani
merged commit 2874b6a
into
astarte-platform:feature/erlang-rpc
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1191
Requires astarte-platform/astarte_vmq_plugin#102
This PR moves the communication between AppEngine and the Astarte VerneMQ Plugin outside of
astarte_rpc. The new strategy consists in having an rpc server shared among all VerneMQ Plugin replicas (see astarte-platform/astarte_vmq_plugin#102 for context) and making RPC calls to shuch server. AppEngine calls have to be reworked to accomodate for the changes